Bad Null Checks in UniginePhysics.cpp 2.2.1

[dred]

Hi,

 

We are attempting to upgrade to Unigine 2.2.1 and ran into a crash when we try to do some stuff with one of our shapes.  In stepping though code I found line 149 in UniginePhysics.cpp

 

ShapePtr api(::Shape *arg) { return ShapePtr(arg == NULL ? new ShapeInterface(arg) : NULL ); }

 

Which appears to me that if the shape is not NULL it returns NULL.  I think the NULL check got inverted here. 

 

We switched the == to != and it got past that line of code with good data

 

It appears to me that there are a bunch of other inverted null checks in that file.

 

Thanks,

Dusty

[silent]

Hi Dusty,

 

I've created ticket in our internal bug tracker.

 

Thank you for noticing that!